Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serf] new port (build using scons) #41043

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Conversation

rinrab
Copy link
Contributor

@rinrab rinrab commented Sep 17, 2024

In this version on the port, we are going to use the official build system of the library, Scons. There is already a helper for getting it from the internet, but it wasn't actually working, and should be it with Python should be updated.

Included changes:

  • Update scons version to the latest.
  • Using Python3 instead of Python2 for scons.
  • Add the port for Serf library

TODO List:

  • Insure that all Azure Pipelines cases are passing.
  • Check that Subversion can be compiled correctly against Serf from this port.
  • Add the port version.
  • Test the port against different configurations.
  • Add pretty logging.

@rinrab rinrab changed the title [serf] new port (using scons) [serf] new port (build using scons) Sep 17, 2024
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 18, 2024
@rinrab
Copy link
Contributor Author

rinrab commented Sep 18, 2024

It worked on my Linux VM, but fails on Azure Pipelines, due to missing scons on the system. I have a question: how to make it installed there? I've already specified apt_package_name and brew_package_name variables in the vcpkg_find_acquire_program(SCONS).cmake script and it suggests to install this tool.

@rinrab rinrab marked this pull request as ready for review September 18, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants