Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lunarg-vulkantools] Updating port to 1.3.295 #41041

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Honeybunch
Copy link
Contributor

vulkan-headers port will fail to pass CI unless this port is updated as well

#40950

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BillyONeal
Copy link
Member

Closing and reopening to kick CLA bot

@BillyONeal BillyONeal closed this Sep 17, 2024
@BillyONeal BillyONeal reopened this Sep 17, 2024
Comment on lines -6 to 7
REF "vulkan-sdk-${VERSION}"
REF "vulkan-tmp-${VERSION}"
SHA512 6F5081BDA20BDC79CCA89E515B5DA902884562460312FCAE6FDF4DB8029D00401B445E96BD37DA05EA8FB0CC169DE93E2821550DAC90C49CE2EBD7489593F256
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it must be wrong; it's passing in CI because the SHA512 isn't updated

https://github.com/LunarG/VulkanTools/releases/tag/vulkan-tmp-1.3.295 does not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a release but there is a branch https://github.com/LunarG/VulkanTools/tree/vulkan-tmp-1.3.295
I did miss updating the SHA though so I'll make sure to do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you know what, 1.3.295 hasn't been fully released yet. I'm getting ahead of myself with this change. I was mistaken since I saw a notice about VK_KHR_pipeline_binary being released and noticed it in 1.3.295 and made some assumptions. My bad! I'll move this to a draft and come back to it when it's all a little less jank :)

@Honeybunch Honeybunch marked this pull request as draft September 17, 2024 23:15
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants