Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastdds] update to 3.0.1(rename fastrtps) #40984

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[fastdds] update to 3.0.1(rename fastrtps) #40984

wants to merge 2 commits into from
+149 −0

Conversation

miyanyan
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The FastRTPS project has been renamed to the FastDDS, and there's a new version 3.0, so it's time to rename it like #38346, I also found this had been tried in #28181

@miyanyan miyanyan marked this pull request as draft September 15, 2024 02:21
@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 16, 2024
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 18, 2024
@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 19, 2024
@BillyONeal
Copy link
Member

We are happy to take the rename. This PR needs to be fixed to deindex the old one:

  • delete ports/fastrtps
  • delete the entry from versions/baseline.json
  • DO NOT touch anything in versions/f-/fastrtps.json

Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miyanyan @BillyONeal @jimwang118