Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ampl-asl] Update to 20240201 and disable generate host-dependent header #40958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ampl-asl] Update to 20240201 and disable generate host-dependent header #40958

wants to merge 1 commit into from
+36 −141

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Sep 13, 2024 •
edited
Loading

Related #40503

  • Disable generating host-dependent header, use pre-provided header for cross compiling
  • Update to 2024-02-01 ampl/asl@2f5d9de
  • Remove upstream merged patches
  • Clean and set license to BSD-3-Clause
  • Support with !uwp for src/solvers/func_add.c(436): error C2065: '_pclose': undeclared identifier since the function not available to UWP apps.
  • Change ampl-mp dependency unofficial-asl to ampl-asl

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port usage tests pass with the following triplets:

  • x64-windows
  • x86-windows (With CMAKE_CROSSCOMPILING)

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Sep 13, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [ampl-asl] Update to 20240201 and fix cross compiling [ampl-asl] Update to 20240201 and disable generate host-dependent header Sep 13, 2024
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/ampl-asl/upgrade-20240201 branch 2 times, most recently from 6aae384 to ea5517f Compare September 14, 2024 03:07
@WangWeiLin-MV WangWeiLin-MV mentioned this pull request Sep 14, 2024
Merged
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review September 18, 2024 02:41
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WangWeiLin-MV @MonicaLiu0311