Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jwt-cpp] Enforce SSL library dependency #41058

Open
martingalvan-volue opened this issue Sep 18, 2024 · 0 comments · May be fixed by #41079
Open

[jwt-cpp] Enforce SSL library dependency #41058

martingalvan-volue opened this issue Sep 18, 2024 · 0 comments · May be fixed by #41079
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@martingalvan-volue
Copy link
Contributor

martingalvan-volue commented Sep 18, 2024

Is your feature request related to a problem? Please describe.

It seems like jwt-cpp requires an SSL library to work, and supports a few different ones as indicated in its Readme: https://github.com/Thalhammer/jwt-cpp?tab=readme-ov-file#ssl-compatibility

However, the jwt-cpp port doesn't have any such dependencies in its vcpkg.json, which breaks builds which use jwt-cpp unless the user installs an SSL library and links his final target with it.

Proposed solution

I'm not sure how vcpkg normally handles ports which allow the user to select between various different dependencies, but it would be good to have a way to automatically install the SSL libraries so that builds work out-of-the-box. Perhaps by having different jwt-cpp targets?

In the worst case scenario there could be at least a usage file explaining this.

@martingalvan-volue martingalvan-volue added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 18, 2024
@dg0yt dg0yt linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants