Java codegen, use TCGC enum name for MPG #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
XiaofeiCao
commented
Sep 2, 2024
•
XiaofeiCao
commented
- fix tsp, honor name for Enum in TypeSpec Azure/autorest.java#2940
- test generated with no diff
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
|
is there any test to cover this? |
weidongxu-microsoft
approved these changes
Sep 3, 2024
Yeah, I'm adding that. I'll skip Swagger fluent-test for now since currently we don't have that in microsoft/typespec. |
|
The repo is not yet up-to-date, so local test would do, at present. |
XiaofeiCao
commented
Sep 3, 2024
...re/resourcemanager/models/commontypes/managedidentity/models/ManagedServiceIdentityType.java
Show resolved
Hide resolved
XiaofeiCao
commented
Sep 3, 2024
...re/resourcemanager/models/commontypes/managedidentity/models/ManagedServiceIdentityType.java
Show resolved
Hide resolved
XiaofeiCao
requested review from
srnagar and
haolingdong-msft
as code owners
haolingdong-msft
approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
- Part of #4315, though before TypeSpec ARM fix, we'll probably will not merge that PR
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
…4334) - Part of microsoft#4315, though before TypeSpec ARM fix, we'll probably will not merge that PR
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.