Add miscellaneous simple settings to the settings UI #17923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1839,4 +1871,20 @@ | |||
| <value>Non-monospace fonts:</value> | |||
| <comment>This is a label that is followed by a list of proportional fonts.</comment> | |||
| </data> | |||
| <data name="Profile_RainbowSuggestions.Header" xml:space="preserve"> | |||
| <value>Display suggestions UI preview text with rainbow formatting</value> | |||
| <comment>This is a label for a setting that, when enabled, applies a rainbow coloring to the previewable text from the suggestions UI.</comment> | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
carlos-zamora
force-pushed
the
dev/cazamor/sui/misc-simple-settings
branch
from
0c7979c
to
c895a73
Compare
DemoInteraction page
Appearance page
Profile > Advanced
Profile > Appearance
|
carlos-zamora
commented
Sep 12, 2024
Comment on lines
+139
to
+143
| <!-- Enable Unfocused Acrylic --> | ||
| <local:SettingContainer x:Uid="Globals_EnableUnfocusedAcrylic"> | ||
| <ToggleSwitch IsOn="{x:Bind ViewModel.EnableUnfocusedAcrylic, Mode=TwoWay}" | ||
| Style="{StaticResource ToggleSwitchInExpanderStyle}" /> | ||
| </local:SettingContainer> |
There was a problem hiding this comment.
Noticed that this setting is compatibility.enableUnfocusedAcrylic. Any ideas why it's in the compatibility namespace? To me, it makes sense to have in the appearance page, but the compatibility namespace is making me second guess that it should be in the new compatibility page. Should we remove the compatibility prefix?
There was a problem hiding this comment.
I think it was more "OS compatibility" - unfocused acrylic is actually a different implementation of acrylic than usual. It has caused some issues in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds the following settings to the settings UI:
Additionally, the following settings have graduated from experimental 🎓:
Part of #10000