Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mica Alt support (#17650) #17858

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

typenoob
Copy link

@typenoob typenoob commented Sep 4, 2024

Summary of the Pull Request

  1. Changing the existing $theme.$window.useMica property in the settings from a straight boolean to a string enum $theme.$window.micaStyle
  • "default" (stands for not using mica)
  • "original" (stands for using original mica)
  • "alt" (stands for using mica alt)
  1. Implement mica alt by using DWMSBT_TABBEDWINDOW in DWM_SYSTEMBACKDROP_TYPE enumeration

References and Relevant Issues

#17650

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Change $theme.$window.micaStyle property in the setting.json, see the performances of the window theme

  • "default" (performs the same as useMica=false)
  • "original" (performs the same as useMica=true)
  • "alt" (performs Mica Alt theme)

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

This comment has been minimized.

@typenoob
Copy link
Author

typenoob commented Sep 4, 2024

@typenoob please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant