Add action for opening settings directory in file explorer #17690
+82
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directory and copy settings file path to clipboard)
|
Sorry for the delay! We've been understaffed this week 🙂 |
|
No worries, no rush on my end. |
lhecker
approved these changes
Aug 20, 2024
| openFolder(CascadiaSettings::SettingsDirectory()); | ||
| break; | ||
| case SettingsTarget::Clipboard: | ||
| copyToClipboard(CascadiaSettings::SettingsPath().c_str()); |
There was a problem hiding this comment.
The .c_str() is unnecessary, if not detrimental, because constructing a string-view from a nullptr is UB.
There was a problem hiding this comment.
Updated. (Sorry, I should have thought that through)
Let me know if I should remove the other 2 actions. Fwiw, the send input one is what I have found most useful, I don't think I have ever actually used the other 2 outside of testing. But that is probably just because of my personal workflows.
lhecker
added
Area-User Interface
_copyToClipboard when copying settings file path to clipboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the logic is taken from the original PR (#15417) and adapted to work with the palette.
I added 2 additional actions, send settings file path as input and copy settings file path to clipboard. (Totally understand if these should be removed)
Summary of the Pull Request
References and Relevant Issues
#12382
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist