Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add the background back to
showTabsInTitlebar: false
's tab row. (#1…
…3144) We're doing it this way because ThemeResources are tricky. We default in XAML to using the appropriate ThemeResource background color for our TabRow. When tabs in the titlebar are _disabled_, this will ensure that the tab row has the correct theme-dependent value. When tabs in the titlebar are _enabled_ (the default), we'll switch the BG to Transparent, to let the Titlebar Control's background be used as the BG for the tab row. We can't do it the other way around (default to Transparent, only switch to a color when disabling tabs in the titlebar), because looking up the correct ThemeResource from and App dictionary is a capital-H Hard problem. * [x] Closes #13143 * [x] I work here * [x] validated manually: - [x] showTabsInTitlebar: false, true - [x] useAcrylicInTabRow: false, true - [x] theme: light, dark * [x] Need to check if this is regressed the same in 1.13. I suspect it is. (cherry picked from commit 4c33353) Service-Card-Id: 82298857 Service-Version: 1.13
- Loading branch information