Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MSBUILD env variable #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

phated
Copy link

@phated phated commented Aug 9, 2020

I'm using this action to build CPython in an environment with a "scrubbed" PATH, and their build scripts expect an env var named MSBUILD.

Would it make sense to export that env var from this action for later steps to use?

@jwillemsen
Copy link

Maybe make the name of the expected env var an option, you need MSBUILD but maybe someone else needs a different name

@timheuer
Copy link
Member

@phated does the tool allow you to override and provide the path or it's hard-coded to look for MSBUILD env?

@phated
Copy link
Author

phated commented Aug 28, 2020

@timheuer it's actually the CPython build process itself. And yeah, they look for the MSBUILD env variable first, then search in the path. Usually searching in the path is fine, but some build environments need to use a scrubbed path for clean builds, so having the MSBUILD env variable set still allows for the CPython build to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants