.Net Agents - Streaming Bug Fix and Support Additional Assistant Option #8852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
bug
crickman
had a problem deploying
to
integration
GitHub Actions
Error
crickman
had a problem deploying
to
integration
GitHub Actions
Error
crickman
temporarily deployed
to
integration
GitHub Actions
Inactive
crickman
temporarily deployed
to
integration
GitHub Actions
Inactive
dmytrostruk
approved these changes
Sep 17, 2024
moonbox3
approved these changes
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
crickman
temporarily deployed
to
integration
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ithub.com/microsoft/semantic-kernel into fix_agent_streaming_and_assistant_options
markwallace-microsoft
added
the
kernel
crickman
had a problem deploying
to
integration
GitHub Actions
Error
dmytrostruk
approved these changes
Sep 17, 2024
crickman
temporarily deployed
to
integration
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
crickman
had a problem deploying
to
integration
GitHub Actions
Error
dmytrostruk
approved these changes
Sep 17, 2024
crickman
temporarily deployed
to
integration
GitHub Actions
Inactive
crickman
removed
the
PR: ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Respond to two customer identified issues:
Add support for
AdditionalInstructionsfor creating an assistant as well as invocation override.Fixes .Net: New Feature: Support additional properties available in
RunCreationOptionsviaOpenAIAssistantInvocationOptions#8715Fix issue with duplicated tool-call result when using
ChatCompletionAgentstreamingFixes Bug: Agent streaming duplicates message when IAutoFunctionInvocationFilter uses Terminate #8825
Description
AdditionalInstructionsoption wasn't included in the V2 migration as oversight. This is a pure addition.AdditionalInstructionsoption.ChatCompletionAgentIAutoFunctionInvocationFilter:Concepts/Agents/ChatCompletion_FunctionTerminationContribution Checklist