.Net: unsealing the AgentGroupChat, AgentChat, and AggregatorAgent classes … #8720
+207
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and having them implement corresponding interfaces (IAgentGroupChat, IAgentChat). This change will greatly enhance the extensibility and flexibility
github-actions
bot
changed the title
joslat
had a problem deploying
to
integration
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and having them implement corresponding interfaces (IAgentGroupChat, IAgentChat). This change will greatly enhance the extensibility and flexibility
Motivation and Context
Description
I propose unsealing the AgentGroupChat, AgentChat, and AggregatorAgent classes and having them implement corresponding interfaces (IAgentGroupChat, IAgentChat). This change will greatly enhance the extensibility and flexibility of the Semantic Kernel, allowing developers to extend and customize these classes to suit various application needs.
Benefits:
Enables inheritance for customization and extension.
Promotes programming against abstractions.
Improves testability through easier mocking.
Aligns with SOLID design principles.
Encourages community contributions and ecosystem growth.
I believe these changes will benefit the community and align with the project's goals. I'm open to feedback and willing to adjust the proposal as needed.
Contribution Checklist