.Net: Refactor AssemblyAI connector to use AssemblyAI SDK #8556
Conversation
Swimburger
changed the base branch from
main
to
feature-connectors-assemblyai
markwallace-microsoft
added
.NET
...src/Connectors/Connectors.AssemblyAI.UnitTests/Services/AssemblyAIAudioToTextServiceTests.cs
Outdated
Show resolved
Hide resolved
...src/Connectors/Connectors.AssemblyAI.UnitTests/Services/AssemblyAIAudioToTextServiceTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.AssemblyAI/AssemblyAIAudioToTextExecutionSettings.cs
Outdated
Show resolved
Hide resolved
| this._pollingTimeout = value; | ||
| } | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public override PromptExecutionSettings Clone() |
There was a problem hiding this comment.
Add new properties to clone method also.
There was a problem hiding this comment.
Should I deep clone TranscriptParams?
There was a problem hiding this comment.
Yep, avoid any reference changes, on the original and cloned.
dotnet/src/Connectors/Connectors.AssemblyAI/AssemblyAIClientFactory.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.AssemblyAI/AssemblyAIServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -57,17 +53,27 @@ public async Task<IReadOnlyList<TextContent>> GetTextContentsAsync( | |||
| { | |||
| Verify.NotNull(content); | |||
|
|
|||
| if (executionSettings?.ExtensionData is not null && executionSettings.ExtensionData.Count > 0) | |||
There was a problem hiding this comment.
Would be nice (if possible) support generic ExtensionData instead throwing exception.
There was a problem hiding this comment.
I agree. Unfortunately, we cannot send arbitrary JSON via the SDK, but we could convert the params into JSON and the extension data, merge the JSON objects, and then deserialize it back to the params class. Extension data that doesn't map to the object would still be omitted.
dotnet/src/IntegrationTests/Connectors/AssemblyAI/AssemblyAIFilesTests.cs
Outdated
Show resolved
Hide resolved
- Remove Resharper comments - Update AssemblyAIAudioToTextExecutionSettings.Clone method - Inline creation of AssemblyAIClient (remove AssemblyAIClientFactory) - Catch HttpRequestExceptions and wrap in HttpOperationException - Catch ApiException and wrap in HttpOperationException - Catch TranscriptNotCompletedStatusException and wrap in KernelException - Move JSON stub responses to files
There was a problem hiding this comment.
This service can be dropped, as we did for the OpenAIFIleService, since they have an SDK for file management, and this is not related to an AIService, suggest recommending usage of the SDK client directly
dotnet/Directory.Packages.props
Outdated
| @@ -30,7 +31,7 @@ | |||
| <PackageVersion Include="Microsoft.Bcl.TimeProvider" Version="8.0.1" /> | |||
| <PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="8.0.0" /> | |||
| <PackageVersion Include="Microsoft.Identity.Client" Version="4.64.0" /> | |||
| <PackageVersion Include="Microsoft.ML.OnnxRuntime" Version="1.19.2" /> | |||
There was a problem hiding this comment.
Revert those unrelated changes.
|
Fix small format issues. |
Motivation and Context
Description
By using the SDK, users can use the
TranscriptOptionalParamsclass from the SDK to pass parameters to the AssemblyAI transcription endpoint.Contribution Checklist