.Net: [Draft] main -> feature-connectors-assemblyai #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation and Context AssemblyAI is a speech AI company and SK provides a new `IAudioToTextService` for different connectors to implement. ### Description I added a connector for AssemblyAI that implements `IAudioToTextService`. The `AssemblyAIAudioToTextService` accepts `AudioContent` as mandated by the interface, but also a `Stream` as discussed [here](#4932), a `FileInfo`, and a `Uri`. Remarks: - I couldn't run tests in Connectors.UnitTests because of compilation issues in referenced projects, but I could verify the functionality in the integration tests. - We're working on our C# SDK, so the code will be updated once our C# SDK lands. Questions: - How should I set up the icon and README.md file in this connector project? - Should the `IAudioToTextService` interface accept `PromptExecutionSettings`? It seems a little odd to me since this isn't prompting an LLM. - Which of these overloads makes sense to pull into `IAudioToTextService`? I added `Stream`, `FileInfo`, and `Uri` to our implementation. Upcoming changes. - Change AudioAbstractions to accept an IAsyncEnumerable<StreamingAudioContent> instead of AudioStreamContent class. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <[email protected]>
AssemblyAI is a speech AI company and SK provides a new `IAudioToTextService` for different connectors to implement. I added a connector for AssemblyAI that implements `IAudioToTextService`. The `AssemblyAIAudioToTextService` accepts `AudioContent` as mandated by the interface, but also a `Stream` as discussed [here](#4932), a `FileInfo`, and a `Uri`. Remarks: - I couldn't run tests in Connectors.UnitTests because of compilation issues in referenced projects, but I could verify the functionality in the integration tests. - We're working on our C# SDK, so the code will be updated once our C# SDK lands. Questions: - How should I set up the icon and README.md file in this connector project? - Should the `IAudioToTextService` interface accept `PromptExecutionSettings`? It seems a little odd to me since this isn't prompting an LLM. - Which of these overloads makes sense to pull into `IAudioToTextService`? I added `Stream`, `FileInfo`, and `Uri` to our implementation. Upcoming changes. - Change AudioAbstractions to accept an IAsyncEnumerable<StreamingAudioContent> instead of AudioStreamContent class. - [ ] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <[email protected]>
…crosoft/semantic-kernel into feature-connectors-assemblyai
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Niels Swimberghe <[email protected]>
markwallace-microsoft
added
.NET
…nto upstream/feature-connectors-assemblyai
RogerBarreto
had a problem deploying
to
integration
GitHub Actions
Failure
RogerBarreto
had a problem deploying
to
integration
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR FOR VISIBILITY ONLY (IN PROGRESS)