test(e2e-cilium): add e2e test for cilium event observer plugin #665
Conversation
snguyen64
force-pushed
the
feat/cilium-update
branch
from
536dd96
to
91eb27e
Compare
snguyen64
force-pushed
the
feat/cilium-update
branch
from
18823e1
to
50f51db
Compare
| promAddress := fmt.Sprintf("http://localhost:%s/metrics", v.PortForwardedHubblePort) | ||
|
|
||
| metric := map[string]string{ | ||
| directionKey: v.Direction, reasonKey: PolicyDenied, |
There was a problem hiding this comment.
should this be v.Reason instead
There was a problem hiding this comment.
sicne this is advanced, we want to check the full metric presence, including source or destination
There was a problem hiding this comment.
hubble dataplane has bug with enrichement so source and destination will be empty unless we change the flow egress context in values.yaml from pod to IP. This will not fix the underlying issue though, so we should probably wait until that is fixed and then update the e2e tests.
test/e2e/scenarios/ciliumeventobserver/validate-ciliumeventobserver-metric.go
Outdated
Show resolved
Hide resolved
snguyen64
force-pushed
the
feat/cilium-update
branch
from
90589cb
to
ef09dd9
Compare
| @@ -0,0 +1,3 @@ | |||
| enabledPlugin_linux: '["dns", "ciliumeventobserver"]' | |||
There was a problem hiding this comment.
for non go code, would it be possible to add a go-esque registry using embed fs that we can determine if these files exist at runtime? check this out:
https://github.com/Azure/azure-container-networking/blob/master/test/e2e/manifests/manifests_test.go
that way we know values.yaml exists in the path we expect, and less prone for e2e's failing 20 minutes in because a yaml/manifest is missing or in a wrong directory
There was a problem hiding this comment.
Looks like this will run sequentially, can we make it run in parallel, preferably in another gh workflow stage so we can see output separately for both clusters.
You might want to add anoher one of this
retina/.github/workflows/images.yaml
Line 197 in 32ecf7e
Description
E2e tests for ciliumeventobserver. This runs on hubble helm install of retina on a cilium dataplane.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.