Fixed an issue in type evaluation of call expressions where the calla… #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble subexpression evaluates to a union, and the callable subtypes have different signatures. Pyright was previously caching the types from the first subtype, so it didn't re-evaluate using the second subtype (which may require bidirectional type inference). This addresses #5428.
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/test/versions.py:101:49 - error: Argument of type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to parameter "other" of type "ClosedOpenRange | ConcreteVersion" in function "intersection"
+ /tmp/mypy_primer/projects/spack/lib/spack/spack/test/versions.py:101:49 - error: Argument of type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to parameter "other" of type "ClosedOpenRange | ConcreteVersion" in function "intersection" (reportGeneralTypeIssues)
- Type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to type "VersionList"
- "ClosedOpenRange" is incompatible with "VersionList" (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/test/versions.py:101:49 - error: Argument of type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to parameter "other" of type "ClosedOpenRange | StandardVersion" in function "intersection"
+ /tmp/mypy_primer/projects/spack/lib/spack/spack/test/versions.py:101:49 - error: Argument of type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to parameter "other" of type "ClosedOpenRange | StandardVersion" in function "intersection" (reportGeneralTypeIssues)
- Type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to type "VersionList"
- "ClosedOpenRange" is incompatible with "VersionList" (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/test/versions.py:106:42 - error: Argument of type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to parameter "other" of type "ClosedOpenRange | StandardVersion" in function "union"
+ /tmp/mypy_primer/projects/spack/lib/spack/spack/test/versions.py:106:42 - error: Argument of type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to parameter "other" of type "ClosedOpenRange | StandardVersion" in function "union" (reportGeneralTypeIssues)
- Type "VersionList | ClosedOpenRange | StandardVersion | GitVersion" cannot be assigned to type "VersionList"
- "ClosedOpenRange" is incompatible with "VersionList" (reportGeneralTypeIssues)
dd-trace-py (https://github.com/DataDog/dd-trace-py)
- Type "IPv4Network | IPv6Network" cannot be assigned to type "IPv4Network"
+ Type "IPv4Network | IPv6Network" cannot be assigned to type "IPv6Network"
- "IPv6Network" is incompatible with "IPv4Network" (reportGeneralTypeIssues)
+ "IPv4Network" is incompatible with "IPv6Network" (reportGeneralTypeIssues)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble subexpression evaluates to a union, and the callable subtypes have different signatures. Pyright was previously caching the types from the first subtype, so it didn't re-evaluate using the second subtype (which may require bidirectional type inference). This addresses #5428.