Fixed a bug that resulted in a false positive when an expression of t… #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype `type[Self]` was used as the base type for a member access expression that was then used to call an instance method on that class. This addresses #5530.
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
+ /tmp/mypy_primer/projects/steam.py/steam/chat.py:205:32 - error: Argument of type "GroupChannel | ClanChannel" cannot be assigned to parameter "channel" of type "Channel[Self@ChatMessage[AuthorT@ChatMessage, MemberT@ChatMessage]]" in function "__init__"
+ Type "GroupChannel | ClanChannel" cannot be assigned to type "Channel[Self@ChatMessage[AuthorT@ChatMessage, MemberT@ChatMessage]]"
+ "ClanChannel" is incompatible with "Channel[Self@ChatMessage[AuthorT@ChatMessage, MemberT@ChatMessage]]"
+ Type parameter "MessageT@Channel" is covariant, but "ClanMessage[PartialMember | ClanMember]" is not a subtype of "Self@ChatMessage[AuthorT@ChatMessage, MemberT@ChatMessage]" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/steam.py/steam/message.py:75:32 - error: Argument of type "UserChannel" cannot be assigned to parameter "channel" of type "Channel[Self@UserMessage[UserMessageAuthorT@UserMessage]]" in function "__init__"
+ "UserChannel" is incompatible with "Channel[Self@UserMessage[UserMessageAuthorT@UserMessage]]"
+ Type parameter "MessageT@Channel" is covariant, but "UserMessage[User | Friend | ClientUser]" is not a subtype of "Self@UserMessage[UserMessageAuthorT@UserMessage]" (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/steam.py/steam/models.py:187:20 - error: Could not bind method "(unnamed)" because "type[_IOMixin]" is not assignable to parameter "self"
- Type "type[Self@_IOMixin]" cannot be assigned to type "Self@_IOMixin" (reportGeneralTypeIssues)
- 8666 errors, 45 warnings, 0 informations
+ 8667 errors, 45 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ype
type[Self]was used as the base type for a member access expression that was then used to call an instance method on that class. This addresses #5530.