Further refactored the internal implementation of `validateCallArgume… #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts` into subroutines so it is easier to maintain. Fixed a few small bugs that I discovered along the way.
|
Diff from mypy_primer, showing the effect of this PR on open source code: freqtrade (https://github.com/freqtrade/freqtrade)
- /tmp/mypy_primer/projects/freqtrade/freqtrade/rpc/telegram.py:1108:67 - error: Argument of type "list[Never]" cannot be assigned to parameter "buttons" of type "List[Module("freqtrade.rpc.telegram.InlineKeyboardButton")]" in function "_layout_inline_keyboard_onecol"
- "list[Never]" is incompatible with "List[Module("freqtrade.rpc.telegram.InlineKeyboardButton")]"
- Type parameter "_T@list" is invariant, but "Never" is not the same as "Module("freqtrade.rpc.telegram.InlineKeyboardButton")" (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/freqtrade/freqtrade/rpc/telegram.py:1194:60 - error: Argument of type "list[Never]" cannot be assigned to parameter "buttons" of type "List[Module("freqtrade.rpc.telegram.InlineKeyboardButton")]" in function "_layout_inline_keyboard"
- "list[Never]" is incompatible with "List[Module("freqtrade.rpc.telegram.InlineKeyboardButton")]"
- Type parameter "_T@list" is invariant, but "Never" is not the same as "Module("freqtrade.rpc.telegram.InlineKeyboardButton")" (reportGeneralTypeIssues)
- 556 errors, 37 warnings, 0 informations
+ 554 errors, 37 warnings, 0 informations
dd-trace-py (https://github.com/DataDog/dd-trace-py)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/contrib/tornado/stack_context.py:63:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psaix.py:324:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psaix.py:326:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psaix.py:328:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psaix.py:516:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psaix.py:552:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:559:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:561:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:563:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:567:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:584:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:586:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:588:15 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:662:31 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psbsd.py:664:31 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1519:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1521:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1524:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1629:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1631:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1633:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1868:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:1870:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pslinux.py:2016:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psosx.py:340:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psosx.py:342:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psosx.py:344:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psosx.py:367:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psosx.py:369:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_psposix.py:68:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:353:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:355:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:357:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:361:27 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:460:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:622:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pssunos.py:624:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:559:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:565:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:709:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:735:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:796:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:833:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:880:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:916:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:937:23 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/_pswindows.py:998:19 - error: Invalid exception class or object
- "Never" does not derive from BaseException (reportGeneralTypeIssues)
- 8277 errors, 418 warnings, 0 informations
+ 8230 errors, 418 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nts` into subroutines so it is easier to maintain. Fixed a few small bugs that I discovered along the way.