Add fsevents as optional dependency to public package #5503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should resolve #5415, but I'm not an expert here. My understanding is that the published pyright package does the npm equivalent of statically linking the chokidar dependency, which means that fsevents is not pulled in if that linking is done on a machine that is not run on MacOS.
This setup is not ideal since the version could drift from the one expected the chokidar embedded in
pyright
, but I think it's probably okay.