Match CPython's __hash__ overriding behavior when __eq__ exists #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: bidict (https://github.com/jab/bidict)
+ /tmp/mypy_primer/projects/bidict/tests/property_tests/test_properties.py:357:13 - error: Set entry must be hashable
+ Type "Bi" is not hashable (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/bidict/tests/property_tests/test_properties.py:358:13 - error: Dictionary key must be hashable
+ Type "Bi" is not hashable (reportGeneralTypeIssues)
- 12 errors, 0 warnings, 0 informations
+ 14 errors, 0 warnings, 0 informations
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ /tmp/mypy_primer/projects/pandas-stubs/tests/test_pandas.py:157:23 - error: Argument of type "list[DataFrame]" cannot be assigned to parameter "objs" of type "Iterable[Series[Unknown]] | Mapping[HashableT1@concat, Series[Unknown]]" in function "concat"
+ "DataFrame" is incompatible with "Series[Unknown]"
+ "DataFrame" is incompatible with "Series[Unknown]" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/pandas-stubs/tests/test_pandas.py:157:62 - error: Argument of type "list[Timedelta]" cannot be assigned to parameter "names" of type "list[HashableT4@concat]" in function "concat"
+ Type "Timedelta" cannot be assigned to type "Hashable"
+ "Timedelta" is incompatible with protocol "Hashable"
+ "__hash__" is an incompatible type
+ Type "None" cannot be assigned to type "(self: Timedelta) -> int" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/pandas-stubs/tests/test_pandas.py:157:13 - error: "assert_type" mismatch: expected "DataFrame" but received "Unknown" (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/pandas-stubs/tests/test_pandas.py:1601:13 - error: Dictionary key must be hashable
+ Type "Timestamp" is not hashable (reportGeneralTypeIssues)
+ /tmp/mypy_primer/projects/pandas-stubs/tests/test_pandas.py:1602:13 - error: Dictionary key must be hashable
+ Type "Timedelta" is not hashable (reportGeneralTypeIssues)
- 1243 errors, 0 warnings, 0 informations
+ 1248 errors, 0 warnings, 0 informations
Expression (https://github.com/cognitedata/Expression)
+ /tmp/mypy_primer/projects/Expression/expression/collections/map.py
+ /tmp/mypy_primer/projects/Expression/expression/collections/map.py:215:5 - error: "__hash__" overrides symbol of same name in class "Mapping"
+ Type cannot be assigned to type "None" (reportIncompatibleVariableOverride)
+ /tmp/mypy_primer/projects/Expression/expression/collections/map.py:215:5 - error: Instance variable "__hash__" overrides class variable of same name in class "Mapping" (reportIncompatibleVariableOverride)
- 278 errors, 0 warnings, 0 informations
+ 280 errors, 0 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/python/cpython/blob/main/Objects/typeobject.c#L6794 checks if
__hash__is overridden (__eq__or__hash__is defined) and stops__hash__from being copied from the base (https://github.com/python/cpython/blob/main/Objects/typeobject.c#L6953). https://github.com/python/cpython/blob/main/Objects/typeobject.c#L7354 sets__hash__toNoneif__hash__isn't found in the dict.This should match CPython's behavior.
closes #5446