Fixed recent regression in the synthesized TypedDict get method, wh…

…ich resulted in a false positive error when using strict mode. This addresses #5452.
microsoft · Jul 11, 2023 · 1e03e38 · 1e03e38
1 parent c41bc9c
commit 1e03e38
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/packages/pyright-internal/src/analyzer/typedDicts.ts b/packages/pyright-internal/src/analyzer/typedDicts.ts
@@ -554,11 +554,7 @@ export function synthesizeTypedDictClassMethods(
                     )
                 );
                 getOverloads.push(
-                    createGetMethod(
-                        literalStringInstance,
-                        /* valueType */ UnknownType.create(),
-                        /* includeDefault */ true
-                    )
+                    createGetMethod(literalStringInstance, /* valueType */ AnyType.create(), /* includeDefault */ true)
                 );
             }
         }

diff --git a/packages/pyright-internal/src/tests/samples/typedDict12.py b/packages/pyright-internal/src/tests/samples/typedDict12.py
@@ -64,7 +64,7 @@ def func1(a: TD3, b: TD4, c: C, s: str) -> int | None:
     a3 = a.get("bar")
     reveal_type(a3, expected_text="None")
     a4 = a.get("bar", 1.0)
-    reveal_type(a4, expected_text="Unknown | float")
+    reveal_type(a4, expected_text="Any | float")
     a5 = a.get("baz")
     reveal_type(a5, expected_text="int | None")
     a6 = a.get("baz", 1.0)
@@ -94,7 +94,7 @@ def func1(a: TD3, b: TD4, c: C, s: str) -> int | None:
     c3 = c.get("bar")
     reveal_type(c3, expected_text="str | None")
     c4 = c.get("bar", 1.0)
-    reveal_type(c4, expected_text="Unknown | float | str")
+    reveal_type(c4, expected_text="Any | float | str")
     c5 = c.get("baz")
     reveal_type(c5, expected_text="int | Any | None")
     c6 = c.get("baz", 1.0)