Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove unnecessary code from flow_executor.py #3641

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hiroki0525
Copy link
Contributor

@hiroki0525 hiroki0525 commented Aug 11, 2024

Description

I have found that they are not used in the current code in flow_executor.py.
Perhaps they were forgotten to be removed in past changes.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Aug 30, 2024
@hiroki0525
Copy link
Contributor Author

@microsoft/promptflow-sdk
Excuse me, when can I have a review?

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Aug 31, 2024
Copy link

SDK CLI Global Config Test Result remove-unnecessary-code

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8a4f9f6.

Copy link

Executor E2E Test Result remove-unnecessary-code

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8a4f9f6.

Copy link

Executor Unit Test Result remove-unnecessary-code

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8a4f9f6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant