Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert MSI package stop custom action #2901

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Revert MSI package stop custom action #2901

merged 6 commits into from
Apr 19, 2024

Conversation

YingChen1996
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested a review from a team as a code owner April 19, 2024 09:47
wangchao1230
wangchao1230 previously approved these changes Apr 19, 2024
View reviewed changes
@YingChen1996 YingChen1996 changed the title Fix MSI package code to be compatible with older versions Revert MSI package stop custom action Apr 19, 2024
@YingChen1996 YingChen1996 requested a review from a team as a code owner April 19, 2024 11:46
@YingChen1996 YingChen1996 merged commit 1c977e4 into main Apr 19, 2024
11 checks passed
@YingChen1996 YingChen1996 deleted the dev/chenyin/fix_msi_bug branch April 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mza987 0mza987 0mza987 approved these changes

@lalala123123 lalala123123 lalala123123 approved these changes

@elliotzh elliotzh elliotzh approved these changes

@wangchao1230 wangchao1230 wangchao1230 left review comments

Assignees
No one assigned
Labels
fundamental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YingChen1996 @0mza987 @lalala123123 @elliotzh @wangchao1230