test(svelte): migrate svelte-navigator to custom minimal router #30225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
tests/migrate-svelte-navigator-to-svelte-spa-router
branch
from
0668df7
to
befd662
Compare
mxschmitt
changed the title
mxschmitt
force-pushed
the
tests/migrate-svelte-navigator-to-svelte-spa-router
branch
from
befd662
to
825fe5a
Compare
Test results for "tests 1"5 flaky26904 passed, 618 skipped Merge workflow run. |
pavelfeldman
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro:
cd tests/components/ct-svelte && rm -rf node_modules package-lock.json && npm i && npx playwright test --project=chromiumFollow-up based on #28624 (comment).
Svelte has no router by default, only SvelteKit - so lets remove the package which is not maintained anymore and not recommended.