Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate yarn to npm #22116

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+20,519 −13,381
Open

Migrate yarn to npm #22116

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aa79d3b
Migrate yarn to npm
jchen351 Sep 17, 2024
53b3874
npm --prefix e2e install
jchen351 Sep 17, 2024
0b321d6
Update package.json
jchen351 Sep 17, 2024
116f431
Update update_version.py
jchen351 Sep 18, 2024
ce0c841
Update boostrap.js
jchen351 Sep 18, 2024
374d6ae
Update react-native-ci.yml
jchen351 Sep 18, 2024
e3a593b
Adding "e2e:start": "npm --prefix e2e run start"
jchen351 Sep 18, 2024
7a66218
use_react_native!(:path => '../node_modules/react-native')
jchen351 Sep 18, 2024
0a849ad
Trying to update to ios 15.0
jchen351 Sep 18, 2024
52a1723
Trying to update to ios 15.0
jchen351 Sep 18, 2024
108e35f
Adding debug info
jchen351 Sep 18, 2024
ed99966
Rearrange npm install
jchen351 Sep 18, 2024
b27a5f9
Remove reference to react.grale
jchen351 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions js/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ From ORT v1.19 onwards, the ONNX Runtime Mobile packages are no longer published
From `<ORT_ROOT>/js/react_native,

```sh
yarn bootstrap
npm run bootstrap
```

When testing with a custom built ONNX Runtime Android package, copy `<BUILD_DIRECTORY>/aar_out/MinSizeRel/com/microsoft/onnxruntime/onnxruntime-android/<version>/onnxruntime-android-<version>.aar` into the `<ORT_ROOT>/js/react_native/e2e/android/app/libs` directory.
Expand All @@ -377,7 +377,7 @@ From ORT v1.19 onwards, the ONNX Runtime Mobile packages are no longer published
Install detox command line tools:

```
yarn global add detox-cli
npm install -g detox-cli
```

Install applesimutils which is required by Detox to work with iOS simulators. (Requires a MacOS device)
Expand Down Expand Up @@ -439,13 +439,13 @@ From ORT v1.19 onwards, the ONNX Runtime Mobile packages are no longer published
To record logs for testing results, add `--record-logs`. Output logs and test results will be produced in the `e2e/artifacts/` folder.
See: [Detox/logger#artifacts](https://wix.github.io/Detox/docs/api/logger#artifacts)

**_`yarn bootstrap` changes `packages.json` and `yarn.lock` files. Once testing is done, restore changes to avoid unwanted commit._**
**_`npm run bootstrap` changes `packages.json` and `pacakge-lock.json` files. Once testing is done, restore changes to avoid unwanted commit._**

5. Run Android and iOS apps.

```sh
yarn e2e android
yarn e2e ios
npm run e2e:android
npm run e2e:ios
```

### NPM Packaging
Expand All @@ -460,4 +460,4 @@ From ORT v1.19 onwards, the ONNX Runtime Mobile packages are no longer published

### Distribution

It should be able to consumed by React Native projects that uses Yarn packages through `yarn add onnxruntime-react-native`.
It should be able to consumed by React Native projects that uses npm packages through `npm install onnxruntime-react-native`.
2 changes: 1 addition & 1 deletion js/react_native/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ With ONNX Runtime React Native, React Native developers can score pre-trained ON
### Installation

```sh
yarn add onnxruntime-react-native
npm install onnxruntime-react-native
```

### Usage
Expand Down
Loading
Loading