Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Running CI] Update TensorRT to 10.4 #22049

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[Running CI] Update TensorRT to 10.4 #22049

wants to merge 18 commits into from
+68 −66

Conversation

jingyanwangms
Copy link
Contributor

Description

TensorRT 10.4 is GA now, update to 10.4

Motivation and Context

@jingyanwangms jingyanwangms requested a review from a team as a code owner September 10, 2024 23:01
@jingyanwangms jingyanwangms changed the title Jingywa/104 update [Running CI] Update TensorRT to 10.4 Sep 10, 2024
@jingyanwangms jingyanwangms requested a review from a team as a code owner September 12, 2024 23:14
@jywu-msft
Copy link
Member

in case you didn't see the lint error: https://github.com/microsoft/onnxruntime/actions/runs/10845815827/job/30097454301?pr=22049

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 13, 2024
View reviewed changes
tools/ci_build/build.py
Comment on lines +2100 to +2103
# run_subprocess(
# [sys.executable, "onnxruntime_test_python_nested_control_flow_op.py"], cwd=cwd, dll_path=dll_path
# )

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@jingyanwangms
Copy link
Contributor Author

in case you didn't see the lint error: https://github.com/microsoft/onnxruntime/actions/runs/10845815827/job/30097454301?pr=22049
Thank you for reminding. I indeed didn't see this earlier. Somehow lintrunner didn't work on my dev environment, I manually fixed it according to the error message. Let's see if it gets rid of the lint error

@jywu-msft
Copy link
Member

CI's passed but it says there's a conflict on download-deps.yml ?

@jingyanwangms
Copy link
Contributor Author

CI's passed but it says there's a conflict on download-deps.yml ?

download-deps.yml is updated in this PR yesterday: https://github.com/microsoft/onnxruntime/pull/22012/files#diff-d8e6c0a84ed342d916dba4bad7b129cee2349858e3466da9ad7ae90bf3c2232a
Let me refresh my branch

jywu-msft
jywu-msft reviewed Sep 19, 2024
View reviewed changes
cmake/deps.txt
@@ -38,8 +38,8 @@ mimalloc;https://github.com/microsoft/mimalloc/archive/refs/tags/v2.1.1.zip;d5ee
mp11;https://github.com/boostorg/mp11/archive/refs/tags/boost-1.82.0.zip;9bc9e01dffb64d9e0773b2e44d2f22c51aace063
neural_speed;https://github.com/intel/neural-speed/archive/refs/tags/v0.3.zip;5ec64e3071edc7347ebd8a81679cf06e2bb9b851
onnx;https://github.com/onnx/onnx/archive/refs/tags/v1.16.1.zip;2eb9198bb352757d5ff13977cbe0634898e0837c
#use the latest commit of 10.3-GA
onnx_tensorrt;https://github.com/onnx/onnx-tensorrt/archive/62bdde2a04fcd53c2409cb895ee18db445b7e755.zip;980a455b07dfa67aa70b9e49d37dd9d4cdf690a0
# Use the latest commit of 10.4-GA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to point to 10.4-GA-DDS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these deps.txt are only used when building with
--use_tensorrt_oss_parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianleiwu tianleiwu tianleiwu left review comments

@jywu-msft jywu-msft jywu-msft left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingyanwangms @jywu-msft @tianleiwu