Skip to content

Commit

Permalink
Bug fixes (#3596)
Browse files Browse the repository at this point in the history
Fixes #3594
Displays apps not included in Sort-AppFiles (Issue [1131
](microsoft/AL-Go#1131) in AL-Go repo)

---------

Co-authored-by: freddydk <[email protected]>
  • Loading branch information
freddydk and freddydk authored Jul 23, 2024
1 parent 0618f7a commit 6e5de38
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 4 deletions.
10 changes: 8 additions & 2 deletions AppHandling/Run-AlCops.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,14 @@ function Run-AlCops {

$artifactUrl = Get-BcContainerArtifactUrl -containerName $containerName
$artifactVersion = [System.Version]$artifactUrl.Split('/')[4]
$latestSupportedRuntimeVersion = RunAlTool -arguments @('GetLatestSupportedRuntimeVersion',"$($artifactVersion.Major).$($artifactVersion.Minor)")
Write-Host "Latest Supported Runtime Version: $latestSupportedRuntimeVersion"
$latestSupportedRuntimeVersion = ''
try {
$latestSupportedRuntimeVersion = RunAlTool -arguments @('GetLatestSupportedRuntimeVersion',"$($artifactVersion.Major).$($artifactVersion.Minor)")
Write-Host "Latest Supported Runtime Version: $latestSupportedRuntimeVersion"
}
catch {
Write-Host -ForegroundColor Yellow "Cannot determine latest supported runtime version, will skip runtime version compatibility check"
}

$global:_validationResult = @()
$apps | ForEach-Object {
Expand Down
10 changes: 8 additions & 2 deletions AppHandling/Sort-AppFilesByDependencies.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,14 @@ function Sort-AppFilesByDependencies {
if ($includeOnlyAppIds) {
$script:sortedApps | ForEach-Object { $_ | Add-Member -NotePropertyName 'Included' -NotePropertyValue $false }
$includeOnlyAppIds | ForEach-Object { MarkSortedApps -AppId $_ }
$script:sortedApps | Where-Object { $_.Included } | ForEach-Object {
$files["$($_.id):$($_.version)"]
$script:sortedApps | ForEach-Object {
if ($_.Included) {
$files["$($_.id):$($_.version)"]
}
else {
$appName = [System.IO.Path]::GetFileName($files["$($_.id):$($_.version)"])
Write-Host "$appName (AppId=$($_.id)) is skipped as it is not referenced"
}
}
}
else {
Expand Down
3 changes: 3 additions & 0 deletions ReleaseNotes.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
6.0.20
Add trustServerCertificate is the parameter exists in various functions that might be running on the host
Issue #3594 Run-AlCops says unknown platform version
Add information about apps excluded due to not being referenced during Publish-BcContainerApp

6.0.19
Issue #3560 Backup-BcContainerDatabases fails - password must be marked as read only bug
Expand Down

0 comments on commit 6e5de38

Please sign in to comment.