Skip to content

Commit

Permalink
label-issues: Invert functional impact label logic (#48)
Browse files Browse the repository at this point in the history
Fixes #47 

The checkbox exposed to contributors in a PR to determine whether
the PR has a functional impact states:

"Impacts functionality?"

This uses positive logic to simplify understanding by the user.

Currently the `impact:non-functional` label is applied if the
checkbox is checked.

This change inverts the logic to apply the label as expected.

Signed-off-by: Michael Kubacki <[email protected]>
  • Loading branch information
makubacki committed Dec 3, 2022
1 parent 960f5c0 commit 729de2b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ impact:breaking-change:
- '\s*-\s*\[\s*[x|X]\s*\] Breaking change\?'

impact:non-functional:
- '\s*-\s*\[\s*[x|X]\s*\] Impacts functionality\?'
- '\s*-\s*\[\s*(?![x|X])\s*\] Impacts functionality\?'

impact:security:
- '\s*-\s*\[\s*[x|X]\s*\] Impacts security\?'
Expand Down

0 comments on commit 729de2b

Please sign in to comment.