Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TCP listener created sockets to non blocking #4541

Merged
merged 12 commits into from
Sep 10, 2024
Merged

Set TCP listener created sockets to non blocking #4541

Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4336a18
Fill out remote and local addresses on TCP server connection
ThadHouse Sep 8, 2024
41fe971
Fix breaks
ThadHouse Sep 8, 2024
0f9867b
Submodue
ThadHouse Sep 8, 2024
14c4d0c
Fix getsockname again
ThadHouse Sep 8, 2024
b5ae015
One more fix...
ThadHouse Sep 8, 2024
44a4eda
Set TCP listener created sockets to non blocking
ThadHouse Sep 9, 2024
d38b1ae
Merge
ThadHouse Sep 9, 2024
7eaffc4
SEparate read and write
ThadHouse Sep 9, 2024
cb227d8
Bad binding
ThadHouse Sep 9, 2024
6825e4b
Update src/platform/datapath_epoll.c
ThadHouse Sep 9, 2024
3ddd496
Another fix
ThadHouse Sep 9, 2024
863573d
Code check
ThadHouse Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/platform/datapath_epoll.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <linux/filter.h>
#include <linux/in6.h>
#include <netinet/udp.h>
#include <fcntl.h>

#ifdef QUIC_CLOG
#include "datapath_epoll.c.clog.h"
Expand Down Expand Up @@ -1578,6 +1579,42 @@ CxPlatSocketContextAcceptCompletion(
&SocketContext->AcceptSocket->RemoteAddress,
&SocketContext->AcceptSocket->RemoteAddress);

a//
ThadHouse marked this conversation as resolved.
Show resolved Hide resolved
// Set non blocking mode
//
Flags =
fcntl(
SocketContext->AcceptSocket->SocketContexts[0].SocketFd,
F_GETFL,
NULL);
if (Flags < 0) {
Status = errno;
QuicTraceEvent(
DatapathErrorStatus,
"[data][%p] ERROR, %u, %s.",
SocketContext->Binding,
Status,
"fcntl(F_GETFL) failed");
goto Exit;
}

Flags |= O_NONBLOCK;
Result =
fcntl(
SocketContext->AcceptSocket->SocketContexts[0].SocketFd,
F_SETFL,
Flags);
if (Result < 0) {
Status = errno;
QuicTraceEvent(
DatapathErrorStatus,
"[data][%p] ERROR, %u, %s.",
SocketContext->Binding,
Status,
"fcntl(F_SETFL) failed");
goto Exit;
}

CxPlatSocketContextSetEvents(&SocketContext->AcceptSocket->SocketContexts[0], EPOLL_CTL_ADD, EPOLLIN);
SocketContext->AcceptSocket->SocketContexts[0].IoStarted = TRUE;
Status = Datapath->TcpHandlers.Accept(
Expand Down