retry connection if timed out #4329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4329 +/- ##
==========================================
- Coverage 85.68% 81.63% -4.05%
==========================================
Files 56 56
Lines 15384 15384
==========================================
- Hits 13182 12559 -623
- Misses 2202 2825 +623 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
May 30, 2024
| QUIC_LOCALHOST_FOR_AF(QuicAddrFamily), | ||
| ServerLocalAddr.GetPort())); | ||
| do { | ||
| if (Client.GetIsConnected()) { |
There was a problem hiding this comment.
We don't support reusing a connection handle.
|
Can we close this PR, since you added the retry at powershell layer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes test automation reaches the IDLE.TIMEOUT limits (10 sec). then close the connection.
This checks the timeout status and retry connection
#4328
Testing
N/A
Documentation
N/A