-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft km xdp proto #4023
base: main
Are you sure you want to change the base?
draft km xdp proto #4023
Conversation
scripts/performance.ps1
Outdated
$CurrentCommitHash = Get-GitHash -RepoDir $RootDir | ||
$CurrentCommitDate = Get-CommitDate -RepoDir $RootDir | ||
# $CurrentCommitHash = Get-GitHash -RepoDir $RootDir | ||
# $CurrentCommitDate = Get-CommitDate -RepoDir $RootDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this please
scripts/performance.ps1
Outdated
@@ -314,11 +319,12 @@ if ($Local) { | |||
$RemoteDirectory = Invoke-TestCommand -Session $Session -ScriptBlock { | |||
Join-Path (Get-Location) "Tests" | |||
} | |||
$RemoteDirectory = "C:\msquic\artifacts\bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
scripts/performance.ps1
Outdated
@@ -365,34 +371,34 @@ function LocalTeardown { | |||
$RemoteExePath = Get-ExePath -PathRoot $RemoteDirectory -Platform $RemotePlatform -IsRemote $true | |||
$LocalExePath = Get-ExePath -PathRoot $LocalDirectory -Platform $LocalPlatform -IsRemote $false | |||
|
|||
# See if we are an AZP PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this please, as well as all other changes like this
if (TimeoutMs == 0xffffffff) { | ||
return KeWaitForSingleObject(Event, Executive, KernelMode, FALSE, NULL); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? It shouldn't call this function if it's not waiting with a timeout.
|
||
if (IsListEmpty(&queue->Events)) { | ||
CxPlatDispatchLockRelease(&queue->Lock); | ||
CxPlatEventWaitWithTimeout(queue->EventsAvailable, wait_time); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If wait_time
is zero, then we shouldn't lock again.
src/perf/lib/HpsClient.cpp
Outdated
@@ -10,6 +10,7 @@ | |||
--*/ | |||
|
|||
#include "HpsClient.h" | |||
#include <stdlib.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes should be unnecessary in the latest version of secnetperf.
if (Status == QUIC_STATUS_PENDING) { | ||
return QUIC_STATUS_PENDING; | ||
} else { | ||
return Status; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just always return Status
?
@@ -221,6 +221,9 @@ CxPlatWorkersLazyStart( | |||
for (uint32_t i = 0; i < CxPlatWorkerCount; ++i) { | |||
if (CxPlatWorkers[i].InitializedThread) { | |||
CxPlatWorkers[i].StoppingThread = TRUE; | |||
// QuicTraceLogInfo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these are just commented out code. Remove?
This reverts commit 9457dd2.
fa78ca9
to
37e1b3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4023 +/- ##
==========================================
+ Coverage 86.17% 86.85% +0.67%
==========================================
Files 56 56
Lines 16953 16929 -24
==========================================
+ Hits 14610 14704 +94
+ Misses 2343 2225 -118 ☔ View full report in Codecov by Sentry. |
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?