Add tftp deployment on BareMetal platform #3422
Open
+346
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulli2017
force-pushed
the
paull/bm-soc
branch
from
5bbbc1a
to
985e3a4
Compare
squirrelsc
reviewed
Sep 18, 2024
|
|
||
| def __post_init__(self, *args: Any, **kwargs: Any) -> None: | ||
| if self.connection: | ||
| add_secret(self.connection.username, PATTERN_HEADTAIL) |
squirrelsc
reviewed
Sep 18, 2024
squirrelsc
reviewed
Sep 18, 2024
| else: | ||
| self._log.debug("no copied source path specified, skip copy") | ||
|
|
||
| def _process_cluster_elements(self, environment: Environment, log: Logger) -> None: |
There was a problem hiding this comment.
Call it like _predeploy_environment. It should be clearer than "process".
There was a problem hiding this comment.
the change is done, thanks
squirrelsc
reviewed
Sep 18, 2024
| @@ -24,6 +26,28 @@ def __init__(self, runbook: BuildSchema) -> None: | |||
| def type_schema(cls) -> Type[schema.TypedSchema]: | |||
| return BuildSchema | |||
|
|
|||
| @classmethod | |||
| def find_matched_files( | |||
There was a problem hiding this comment.
Move it to a private function in this file.
squirrelsc
reviewed
Sep 18, 2024
| def copy(self, sources_path: List[Path], files_map: List[FileSchema]) -> None: | ||
| assert self.pxe_runbook.connection, "The build server is not specified" | ||
|
|
||
| server_address = self.pxe_runbook.connection.address |
There was a problem hiding this comment.
Create a lisa remotenode, and use the remote_copy tool to copy.
squirrelsc
reviewed
Sep 18, 2024
| return match_files | ||
|
|
||
| try: | ||
| sftp.close() |
There was a problem hiding this comment.
As above comment, it should use remote_copy tool. But the close pattern should like below to avoid leak resource.
try:
try:
transport = paramiko.Transport((server_address, server_port))
transport.connect(
username=server_username,
password=server_password,
)
except Exception as ex:
self._log.exception(
"failed to connect to {server_address}:{server_port}",
exc_info=ex,
)
...
final:
try:
if sftp:
sftp.close()
if transport:
transport.close()
except Exception as ex:
self._log.exception(
"failed to close the connection",
exc_info=ex,
)
paulli2017
force-pushed
the
paull/bm-soc
branch
from
985e3a4
to
733b52a
Compare
paulli2017
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SOC support on BareMetal platform