Support PCI IDs #3420
Draft
Support PCI IDs #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRIKKANTH
force-pushed
the
smyakam/lspci_support_for_ids_14_09_2024
branch
from
56c2acf
to
f17921b
Compare
SRIKKANTH
force-pushed
the
smyakam/lspci_support_for_ids_14_09_2024
branch
4 times, most recently
from
1941252
to
19dca4b
Compare
squirrelsc
reviewed
Sep 16, 2024
| def parse(self, raw_str: str, pci_ids: Dict[str, Any]) -> None: | ||
| matched_pci_device_info = PATTERN_PCI_DEVICE.match(raw_str) | ||
| if matched_pci_device_info: | ||
| self.slot = matched_pci_device_info.group("slot") |
There was a problem hiding this comment.
What's the reason to remove assertions?
squirrelsc
reviewed
Sep 16, 2024
| return device_type_list | ||
|
|
||
| @retry(KeyError, tries=10, delay=20) |
There was a problem hiding this comment.
Why retry can fix key errors?
SRIKKANTH
force-pushed
the
smyakam/lspci_support_for_ids_14_09_2024
branch
from
19dca4b
to
c8ea16b
Compare
This will help in identifying devices even better. Example: NVMe local devices vs remote storage devices when disc controller type == NVMe. An issue with below testcases detected was fixed as part of this PR. stress_sriov_with_max_nics_reboot_from_platform stress_sriov_with_max_nics_stop_start_from_platform Issue: It takes a while to populate/detect all VFs after VM boot. These tests were passing even if not all VF PCI devices were detected. Added 120s wait time to populate all VFs correctly in below testcases to fix the issue.
SRIKKANTH
force-pushed
the
smyakam/lspci_support_for_ids_14_09_2024
branch
from
76bd4a9
to
33623ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help in identifying devices even better.
Example: NVMe local devices vs remote storage devices when disc controller type == NVMe.