io_uring support #3419
Open
io_uring support #3419
+53
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRIKKANTH
force-pushed
the
smyakam/fio_io_uring_03_09_2024
branch
from
8b7c9f3
to
524eea4
Compare
squirrelsc
reviewed
Sep 13, 2024
SRIKKANTH
force-pushed
the
smyakam/fio_io_uring_03_09_2024
branch
2 times, most recently
from
847d358
to
d401259
Compare
SRIKKANTH
force-pushed
the
smyakam/fio_io_uring_03_09_2024
branch
from
d9fefcf
to
2747a2b
Compare
LiliDeng
reviewed
Sep 14, 2024
SRIKKANTH
force-pushed
the
smyakam/fio_io_uring_03_09_2024
branch
from
71564e3
to
81ae9ec
Compare
LiliDeng
reviewed
Sep 16, 2024
Added 'io_uring' support to LISA io perf tests and new testcase 'perf_nvme_io_uring'
SRIKKANTH
force-pushed
the
smyakam/fio_io_uring_03_09_2024
branch
from
500db48
to
09959a5
Compare
squirrelsc
reviewed
Sep 16, 2024
| @@ -37,6 +38,25 @@ class NvmePerformace(TestSuite): | |||
| ), | |||
| ) | |||
| def perf_nvme(self, node: Node, result: TestResult) -> None: | |||
| self._perf_nvme(node, IoEngine.LIBAIO, result) | |||
There was a problem hiding this comment.
Update test case comments to specify what io engine is used.
LiliDeng
requested changes
Sep 19, 2024
| requirement=simple_requirement( | ||
| supported_features=[Nvme], | ||
| ), | ||
| ) |
There was a problem hiding this comment.
for perf_nvme, it has requirement for count of nvme disks, for perf_nvme_io_uring, by default it uses 1 nvme disk, is it expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'io_uring' support to LISA io perf tests and a new testcase 'perf_nvme_io_uring'.
io_uring is advanced alternative for libaio with low system overhead and more io depth.