Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few improvements to source installer #3249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

olshanov
Copy link

@olshanov olshanov commented Apr 4, 2024

  1. Add ability to specify additional build dependencies. For example, Ubuntu 20.04 image provided by Canonical miss zstd package required for kernel build. And Ubuntu 18.04 image lack of cpio package;
  2. Add ability to specify kernel LOCALVERSION for new kernel;
  3. On Ubuntu, new kernel is ignored if it is older then existing kernel;
  4. Add ability to amend kernel config values;

Konstantin Olshanov added 4 commits April 4, 2024 12:51
Signed-off-by: Konstantin Olshanov <[email protected]>
Signed-off-by: Konstantin Olshanov <[email protected]>
Add ability to enable/disable config entry or set it to 'm'.

Signed-off-by: Konstantin Olshanov <[email protected]>
@olshanov
Copy link
Author

olshanov commented Apr 4, 2024

@microsoft-github-policy-service agree company="Cloud Linux"

@@ -264,6 +273,13 @@ def _build_code(self, node: Node, code_path: PurePath, kconfig_file: str) -> Non
sudo=True,
)

result = node.execute(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it optional, if the local_version is not specified, don't execute it.

"EOF\n",
shell=True
)
result.assert_exit_code()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add error message to describe what happened.

)
result.assert_exit_code()

result = node.execute(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be cat into the /etc/default/grub.d/99-lisa.cfg directly? So it doesn't need an extra command to copy.

@squirrelsc
Copy link
Member

@adityagesh @smit-gardhariya @SRIKKANTH Please help checking if there is regression on source installer. Thank you.

@squirrelsc
Copy link
Member

@olshanov please fix check errors. You can refer to document to setup vscode or use nox to validate errors locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants