Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling ASA extension for AzSecPack #3220

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Disabling ASA extension for AzSecPack #3220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion microsoft/testsuites/vm_extensions/azsecpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def verify_azsecpack(self, node: Node, log: Logger, result: TestResult) -> None:
# Install agent extension
try:
self._install_monitor_agent_extension(node)
self._install_security_agent_extension(node, log)
# self._install_security_agent_extension(node, log)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please explain the reason to comment out it in the PR.
  2. Remove the line directly, instead of commenting out.

Copy link
Contributor Author

@suresh-thelkar suresh-thelkar Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to test a specific custom image. In order to run a pipeline I had to raise this PR and then use its GitHub reference in the pipeline. This is the reason I marked the PR as draft.

except HttpResponseError as identifier:
if any(
s in str(identifier)
Expand Down
Loading