Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free bsd firewall #2606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add free bsd firewall #2606

wants to merge 1 commit into from

Conversation

sharsonia
Copy link
Collaborator

No description provided.

@sharsonia sharsonia force-pushed the AddFreeBSDFirewall branch 2 times, most recently from 4eb1efc to f38ac53 Compare February 15, 2023 22:34
lisa/tools/firewall.py Outdated Show resolved Hide resolved
lisa/tools/lsblk.py Outdated Show resolved Hide resolved
@LiliDeng

This comment was marked as outdated.

@LiliDeng

This comment was marked as outdated.

@LiliDeng LiliDeng closed this Apr 13, 2023
@sharsonia sharsonia reopened this May 16, 2023
@sharsonia sharsonia force-pushed the AddFreeBSDFirewall branch 3 times, most recently from 2939e53 to 4f5b62c Compare May 16, 2023 08:02
@squirrelsc
Copy link
Member

@somil55 can you verify it?

lisa/tools/firewall.py Outdated Show resolved Hide resolved


class Ipf(Tool):
_ipf_enable_pattern = re.compile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add few example patterns here?

lisa/tools/firewall.py Show resolved Hide resolved
@squirrelsc
Copy link
Member

@sharsonia, can @somil55 continue on this PR?

@sharsonia
Copy link
Collaborator Author

@sharsonia, can @somil55 continue on this PR?

@squirrelsc - Will update this today and test it out

@sharsonia sharsonia force-pushed the AddFreeBSDFirewall branch 9 times, most recently from 391defa to d34481a Compare July 21, 2023 08:12
force_run=True,
)
ipf_enable_found = re.search(self._ipf_enable_pattern, cmd_result)
if ipf_enable_found:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to reload the service using this file rc.conf file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to reload the service using this file rc.conf file?

Hmm think we can do "service ipfilter start" to start IPF.

@sharsonia sharsonia force-pushed the AddFreeBSDFirewall branch 4 times, most recently from 255e72c to 51d9acc Compare July 25, 2023 07:03
@squirrelsc
Copy link
Member

@sharsonia @somil55 any update on this PR? If it's useful, can we merge it with a priority?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants