Adding GPU feature and some dependent tools #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharsonia
force-pushed
the
Add_gpu_feature
branch
2 times, most recently
from
e4f07a3
to
ecb43c3
Compare
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
ecb43c3
to
5dbe723
Compare
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
glima
reviewed
May 14, 2021
squirrelsc
reviewed
May 14, 2021
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
5dbe723
to
81486b0
Compare
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
9b65372
to
e06d939
Compare
squirrelsc
reviewed
May 24, 2021
squirrelsc
reviewed
May 24, 2021
glima
reviewed
May 24, 2021
glima
reviewed
May 24, 2021
sharsonia
force-pushed
the
Add_gpu_feature
branch
2 times, most recently
from
a3c407c
to
e1460ce
Compare
squirrelsc
reviewed
May 25, 2021
squirrelsc
reviewed
May 25, 2021
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
e1460ce
to
6bd0f36
Compare
squirrelsc
reviewed
May 25, 2021
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
6bd0f36
to
f45a5af
Compare
sharsonia
force-pushed
the
Add_gpu_feature
branch
2 times, most recently
from
7293926
to
19b5e28
Compare
glima
reviewed
May 25, 2021
glima
reviewed
May 25, 2021
| def update_packages( | ||
| self, packages: Union[str, Tool, Type[Tool], List[Union[str, Tool, Type[Tool]]]] | ||
| ) -> None: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Any use case for this? What's the role of a test suite in updating stuff?
There was a problem hiding this comment.
It might be used internally say - in case the some package/tool version queried doesn't match the required version then it would need to be updated first.
But yeah it most likely should not be taking in a list.
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
19b5e28
to
bab7c2a
Compare
Added separate install_packages_from_url() Moved wget class under base_tools/ Some cleanups and fixes.
sharsonia
force-pushed
the
Add_gpu_feature
branch
from
bab7c2a
to
810e37b
Compare
squirrelsc
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.