Remove None IO engine

microsoft · Sep 19, 2024 · b29f0b2 · b29f0b2
1 parent 09959a5
commit b29f0b2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lisa/tools/fio.py b/lisa/tools/fio.py
@@ -41,7 +41,6 @@ class IoEngine(Enum):
     IO_URING = "io_uring"
     LIBAIO = "libaio"
     POSIXAIO = "posixaio"
-    NONE = ""
 
     def __str__(self) -> str:
         return self.value
@@ -103,7 +102,7 @@ def launch(
         verify_dump: bool = False,
         verify_fatal: bool = False,
         verify: str = "",
-        ioengine: IoEngine = IoEngine.NONE,
+        ioengine: IoEngine = IoEngine.LIBAIO,
         cwd: Optional[pathlib.PurePath] = None,
     ) -> FIOResult:
         cmd = self._get_command(
@@ -161,7 +160,7 @@ def launch_async(
         verify_dump: bool = False,
         verify_fatal: bool = False,
         verify: str = "",
-        ioengine: IoEngine = IoEngine.NONE,
+        ioengine: IoEngine = IoEngine.LIBAIO,
         cwd: Optional[pathlib.PurePath] = None,
     ) -> Process:
         cmd = self._get_command(
@@ -282,8 +281,6 @@ def _get_command(  # noqa: C901
     ) -> str:
         if isinstance(self.node.os, BSD):
             ioengine = IoEngine.POSIXAIO
-        elif ioengine == IoEngine.NONE:
-            ioengine = IoEngine.LIBAIO
 
         cmd = (
             f"--ioengine={ioengine.value} --filename={filename} "

diff --git a/microsoft/testsuites/performance/common.py b/microsoft/testsuites/performance/common.py
@@ -71,7 +71,7 @@ def perf_disk(
     size_mb: int = 0,
     numjob: int = 0,
     overwrite: bool = False,
-    ioengine: IoEngine = IoEngine.NONE,
+    ioengine: IoEngine = IoEngine.LIBAIO,
     cwd: Optional[pathlib.PurePath] = None,
 ) -> None:
     fio_result_list: List[FIOResult] = []