Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Updated API Compatibility documentation with latest info #662

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Vijay-Nirmal
Copy link
Contributor

  • Updated API Compatibility doc with missed out commands
  • Add documentation for already existing commands but not documented
  • Updated comments in API Compatibility doc to indicate if there is anything missing

Open Question:

  1. Should I add commands from the Redis module in API Compatibility doc? Note: ICYMI, Redis 8 will add most modules to the base image itself.

@badrishc
Copy link
Contributor

Should I add commands from the Redis module in API Compatibility doc?

Thanks for your contributions! There is no need to list modules in there at this point, IMO. We can revisit that later.

@tmikaeld
Copy link

ZREVRANGEBYSCORE was also completed.

@TalZaccai TalZaccai self-requested a review September 18, 2024 18:12
@Vijay-Nirmal
Copy link
Contributor Author

@tmikaeld Thanks for letting me know, updated it as part of this PR

| | MEMORY STATS | ➖ | |
| | [MEMORY USAGE](server.md#memory-usage) | ➕ | |
| | MODULE | ➖ | |
| | [LOLWUT](server.md#lolwut) | ➕ | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think Garnet has support for the LOLWUT command. Need to remove here and the description section for it.

@Vijay-Nirmal
Copy link
Contributor Author

@badrishc My bad. I had noted down in my notes wrongly. It was supposed to be MONITOR (command below LOLWUT), which was already implemented. I have made the changes accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants