-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Latency Tracking Issue #659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/fix-latency-tracking
branch
from
September 13, 2024 22:41
b8842ff
to
2f7b82b
Compare
badrishc
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a latency tracking issue that was caused by moving INFO under ProcessBasicCommands. Because of this, the latency tracking numbers for NET_RS event were not accurate.
We now implicitly consider any command under ProcessBasicCommands and ProcessArrayCommands as "fast" and all other commands (under ProcessOtherCommands and ProcessAdminCommands) as "slow".
For this reason, this PR also moves certain commands that are considered to be slow under ProcessOtherCommands.
Notes
Explicit classification was dropped, and we use the implicit method. The below info is just for future reference. The alternative solution was to explicitly classify the command using the RespCommandsInfo (https://github.com//pull/659/commits/6e5cbc2f63374bd7c904f9a863d0926deff7c400) flags (i.e. "slow", "fast"). However, this solution incurs the following penalty as measured using RepsParseStress below.Main
With checking IsDataCommand()
Using RespCommandsInfo