-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support azure MangedIdentity TokenCredential #590
base: main
Are you sure you want to change the base?
feature: support azure MangedIdentity TokenCredential #590
Conversation
libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs
Show resolved
Hide resolved
How does this feature work exactly? Is it compatible with the older connection strings? And how does it interface with unit tests? |
Assuming the garnet application will run inside of azure (ex: vm / aks) and managed identity will be able to be assigned to the environment
I think this us instead of using a connection string, so any Metadata provided in the connection string will need to be provided in a different way
We might consider using Currently the unit tests don't use the managed identity credential to perform the login |
{ | ||
Assert.Ignore("Azure tests are disabled."); | ||
} | ||
|
||
var AzureTestDirectory = $"{TestContext.CurrentContext.Test.MethodName.ToLowerInvariant()}"; | ||
var configPath = $"{AzureTestDirectory}/test1.config"; | ||
var AzureEmulatedStorageString = "UseDevelopmentStorage=true;"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a unit test that uses the new version of identity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any progress on this? We would need it to be confident that the feature works (now, and in future as the codebase evolves).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hoping to get to this by the end of this week
closes #558
Tests: