Prevent Dev Home crashing when widgets don't supply icons or screenshots #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
guimafelipe,
dkbennett,
EricJohnson327,
lauren-ciha and
AmelBawa-msft
AmelBawa-msft
approved these changes
Sep 16, 2024
| } | ||
|
|
||
| private Grid BuildNavItem(BitmapImage image, string text) | ||
| private async Task<Grid> BuildNavItem(ComSafeWidgetDefinition widgetDefinition) |
There was a problem hiding this comment.
Suggested change
| private async Task<Grid> BuildNavItem(ComSafeWidgetDefinition widgetDefinition) | |
| private async Task<Grid> BuildNavItemAsync(ComSafeWidgetDefinition widgetDefinition) |
guimafelipe
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Widget providers are required to supply icons and screenshots. However, if they don't, Dev Home shouldn't crash.
Simplify icon and screenshot services by just returning a brush. If we can't get the image to put in the brush, the image just won't show up.
References and relevant issues
Related to #2482
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist