Unsubscribe from OnExtensionsChanged when unloading Extensions page #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
guimafelipe,
vineeththomasalex,
dkbennett,
DefaultRyan,
EricJohnson327 and
lauren-ciha
AmelBawa-msft
approved these changes
Sep 13, 2024
guimafelipe
approved these changes
Sep 16, 2024
Comment on lines
+72
to
+73
| _extensionService.OnExtensionsChanged -= OnExtensionsChanged; | ||
| _extensionService.OnExtensionsChanged += OnExtensionsChanged; |
There was a problem hiding this comment.
Why do we do this at all? To trigger some kind of "on subscribe" event?
There was a problem hiding this comment.
So we can update the page when the list changes -- for example, if something shows up in the list of extensions available in the store, and then you install it, you'll see the UI update it from being in that list to the list of installed extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
We saw a crash when the extensions list updated, even though we weren't on the Extensions page. When leaving the page, we should unsubscribe from extension events, since we don't want to respond to them if there's no UI to update. Also, move subscribing out of the constructor and into the Loaded event.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist