Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate tunnel connection is disposed error #411

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Disambiguate tunnel connection is disposed error #411

merged 3 commits into from
Mar 5, 2024

Conversation

jramsay
Copy link
Member

@jramsay jramsay commented Mar 4, 2024

Disambiguate tunnel connection is disposed error

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • [x ] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@jramsay jramsay marked this pull request as ready for review March 4, 2024 23:59
IlyaBiryukov
IlyaBiryukov previously approved these changes Mar 5, 2024
View reviewed changes
@jramsay jramsay merged commit 2d16ff1 into main Mar 5, 2024
11 checks passed
@jramsay jramsay deleted the dev/jasonra/connection-disposed branch March 5, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBiryukov IlyaBiryukov IlyaBiryukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jramsay @IlyaBiryukov