Users/oakeredolu/throttlehttpclient #872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov Report
@@ Coverage Diff @@
## main #872 +/- ##
=======================================
- Coverage 77.5% 74.8% -2.8%
=======================================
Files 235 235
Lines 9953 9960 +7
Branches 0 975 +975
=======================================
- Hits 7719 7455 -264
+ Misses 2234 2232 -2
- Partials 0 273 +273
|
cobya
reviewed
Nov 29, 2023
| this.logger.LogInformation("Getting Python data from {Uri}", uri); | ||
| using var request = new HttpRequestMessage(HttpMethod.Get, uri); | ||
| request.Headers.UserAgent.Add(ProductValue); | ||
| request.Headers.UserAgent.Add(CommentValue); | ||
| request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/vnd.pypi.simple.v1+json")); | ||
| var response = await HttpClient.SendAsync(request); | ||
| this.semaphore.Release(); |
There was a problem hiding this comment.
We should do this within a try-catch-finally block which throws the exception again but releases the semaphore in the finally block so exceptions don't block other threads forever.
| @@ -265,12 +269,14 @@ private async Task<HttpResponseMessage> RetryPypiRequestAsync(Uri uri, PipDepend | |||
| /// <returns> Returns the httpresponsemessage. </returns> | |||
| private async Task<HttpResponseMessage> GetPypiResponseAsync(Uri uri) | |||
| { | |||
| await this.semaphore.WaitAsync(); | |||
There was a problem hiding this comment.
What kind of impact does this have on build times for small / large Python repositories? I see in the description only about 1 case.
cobya
added
status:waiting-on-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr uses semaphore to reduce the amount of http requests to 5 concurrent requests at a time in both pip and simplepip. This is to avoid httpclient timing out due to too many requests at a time.
The fix also seems to have made the cd scan run faster. It was initially taking over 30 minutes to run on the vienna repo locally, but after throttling the requests the scan is taking about 23 minutes.
I also remove the manual disposal of httpclient, since its not recommended to manually dispose it.