Benchmark Conversion of Ptrdist/ft #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtarditi
reviewed
Jun 6, 2017
| @@ -89,30 +91,30 @@ main(int argc, _Array_ptr<const char*> argv : count(argc) ) | |||
| } | |||
|
|
|||
| if(debug) | |||
| { | |||
| _Unchecked { | |||
There was a problem hiding this comment.
You might want to introduce a checked scope after the argument manipulation is done.
There was a problem hiding this comment.
Even better, I added a checked scope for main, and an Unchecked scope just for the argument manipulation
|
Oh I really didn't mean for these commits to be on top of the other branch. I'm going to make your requested changes, rebase, and force push. |
lenary
force-pushed
the
benchmark_conv_ptrdist_ft
branch
from
3a50924
to
1931e28
Compare
|
So this compiles, but something's evidently not correct as we're getting exceptions at run-time. Going to investigate them now. |
|
So even the unchecked version has the bug I found. Hey, we found a bug! |
|
Cool! |
|
So, the issue is related to me increasing the arguments for the large inputs.
With my larger inputs (and asserts disabled, as they are by default in the test suite or Release builds), the unchecked version passes its test, and produces the correct output.
With asserts enabled, the unchecked version fails with an assertion error.
With the conversion to checked C, it always fails, regardless of whether asserts are enabled or not.
This is a result, right?
… On 6 Jun 2017, at 4:14 pm, David Tarditi ***@***.***> wrote:
Cool!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#56 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA41CmsmD1wk3xygKPFYsabHdpNy8VAks5sBd1lgaJpZM4Nw4q5>.
|
|
I need to work out what to increase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully converts Ptrdist/ft.
The execution error alluded to in #32 is fine to ignore - it's to do with
#defined constants and the large input size. Given we're back to using the regular input size for benchmarking, I'm not worried right now about it.I should at some point add in a dynamic_check.