Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: upgrade 1.72.0 -> 1.79.0 to address CVE-2024-32884 #9573

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Jul 3, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Uprade rust 1.72.0 -> 1.79.0 to address CVE-2024-32884

Imp changes:

  • fix UI test (which has a slight delta of what is expected and what is got
  • introduce patch to rebuild flux
  • introduce patch to rebuild kata-containers
  • introduce patch to rebuild kata-containers-cc

NOTE: The tests for rust are failing for unknown reasons, though when run via containerized build, they seem to be working.
Spent more than two weeks to identify the issue and could use some help here.

Change Log
  • rust: upgrade 1.72.0 -> 1.79.0
  • rust: add more doc files to fix build
  • rust: drop rust-doc to fix build
  • flux: introduce patch to rebuild with rust 1.79.0
  • kata-containers: introduce patch to fix rebuild with rust 1.79.0
  • kata-containers-cc: introduce patch to fix rebuild with rust 1.79.0
  • rust: introduce patch to fix ui test
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: [not run yet]
  • Local build without test passes but when built with tests the tests for rust and rpm-ostree fails [could use some help on this]

@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jul 3, 2024
Signed-off-by: Muhammad Falak R Wani <[email protected]>
@jinankjain
Copy link

This upgrade can help ingesting a new version of CloudHypervisor. v40.0 requires minimum rust version as 1.77 https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/Cargo.toml#L18. It would be great if this effort could be expedited for AzureLinux 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants