[Cherry-pick] Update virt_launcher.cil installation path in virt-handler container #10493
Conversation
| @@ -236,6 +236,7 @@ install -p -m 0644 cmd/virt-launcher/qemu.conf %{buildroot}%{_datadir}/kube-virt | |||
| %{_datadir}/kube-virt/virt-handler | |||
| %{_bindir}/virt-handler | |||
| %{_bindir}/virt-chroot | |||
| /virt_launcher.cil | |||
There was a problem hiding this comment.
Is this right? Should this be installed directly under the root folder?
There was a problem hiding this comment.
@harshitgupta1337 .....
There was a problem hiding this comment.
Yes. Kubevirt's virt-handler container expects the file to be present at the path /virt_launcher.cil.
There was a problem hiding this comment.
This doesn't seem right for a package to install something directly under /. Must the virt-handler look for the file only there? It seems like it might be fixed with a configuration change instead of making a package adjust to a tool.
Do you know how this is handled in other distros?
…ler container (#10493) Co-authored-by: Harshit Gupta <[email protected]> nbdkit test failed, but this is known and unrelated to the virt-handler change. (cherry picked from commit cbb0b31)
|
Auto cherry-pick results: Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=642797&view=results |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This PR corrects the path where the SELinux policy virt_launcher.cil is installed in the virt-handler container. A previous commit had incorrectly changed this location, which has caused virt-handler to be unable to find the policy file, resulting in initialization failure of virt-handler.
Change Log
Does this affect the toolchain?
NO